Logevents v111003 analysis/pr-app-MSAW123 s

Logevents v111003 analysis/pr-app-MSAW123 s_keywords-all.html C:\IndigoPerl\bin\perl.exe 5.006

Description This is a legacy report. IAT started with just this report. Use this report to look for keywords that point to potential problems in the software. Some of the more important keywords are TBD and stub. In future releases of software try not to use TBD for items such as future. If you are web enabled, try re-running the report with other keywords. New potential issues may be surfaced.

Analysis	Comment
Keywords	This analysis shows the user selected keywords that were extracted from the original source code. There are also predefined keywords that are seperately reported by the tool in the Problems and Details analysis.
Problems	This analysis summarizes all the problems detected by the automated software analysis.
Details	This analysis shows the details from the original source code that are extracted from the search requests and internal error, warning, and caution settings. It also includes software metrics on a module basis.

Other Analysis Reports . Original Source Code . Instrumented Source Code . Help

12/08/2003 16:09:13

Keyword Stats

Good General Practices

use new and delete instead of malloc and free

do not use ?:

if a func has no parameters, use () instead of (void)

do not use goto

avoid declaring member variable with 'mutable' keyword

avoid declaring local variables with 'register' keyword

avoid declaring local variables with 'static' keyword

avoid do statements - potential endless loops

look for unusual and pertinent keywords

consistency is nice but not mandated

provide if with else

Good Security Practices

the bad fixed keywords are shown elsewhere

terminate case with break;

for each switch, provide default:

default: with security critical data should transfer to SwError

if else sequences with security critical data terminate in SwError

s_ files with if else sequences in many cases terminate in SwError

terminate other as identified if else sequences with SwError

look for undefined error codes in SwError

look for multiple uses of the same error codes

malloc should not be used on security critical data

if malloc is used on security critical data crypto zeroize before free

Number Sort

58	LE SV	5	Free	5	halt	4	TBD	2	?	2	malloc
2	new	2	goto	2	buffer	1	TBS

Alpha Sort

2	?	5	Free	58	LE SV	4	TBD	1	TBS	2	buffer
2	goto	5	halt	2	malloc	2	new

Keywords Not Found

debug	delay
return\;	while\(\d+\).	enable	disable	exception	demo
reuse	pragma	asap	nnoonnee	\bstub\b	\balloc\b
dedicated	timeout	global	delete	mutable	friend
explicit

Possible Problems

Analysis Summary

Details Report

1 1 Source: source/pr-app/pr-app-MSAW123/msaw-01.c
Note: OK Classification Marking
Note: Good Header
 1-15 msaw.1.1
 1-216 A = (long)B + C;
Attention: Recasting (long)

1 1 Result: result/source/pr-app/pr-app-MSAW123/msaw-01.c
2 2 Source: source/pr-app/pr-app-MSAW123/msaw-01.h
Note: OK Classification Marking
Note: Good Header

2 2 Result: result/source/pr-app/pr-app-MSAW123/msaw-01.h

3 3 Source: source/pr-app/pr-app-MSAW123/msaw-02.c
Attention: File s_ Marking wrong or Header Classification blank
your header 
Attention: Possible problem Header
    Possible Missing Fields  BEGIN PROLOGUE CLASSIFICATION FILE NAME ABSTRACT HISTORY CCCQ_VER END PROLOGUE
    Possible Extra Fields 
 2-13 msaw.2.1
 2-165 FreePtr = HmiStringPtr;
Attention: Storage FreePtr = HmiStringPtr;
 2-165 . FreePtr = HmiStringPtr;
 2-217 {
   case one:
   {
      run_this;
      break;
   }
   case two:
   {
      run_this;
      break;
   }
   // missing default
}

A = B/C;
A = B*C;
A = B/C;

if (A eq B)
{
   A = B + C;
   D = E + F;
}


if (A != B)
{
   A = B + C;
   D = E + F;
}


if (A lt B)
{
   A = B + C;
   D = E + F;
}


if (A ge B)
{
   A = B + C;
   D = E + F;
}


if (A != B)
{
   A = B + C;
   D = E + F;
}


if (A <= B)
{
   A = B + C;
   D = E + F;
}


switch (msaw stuff)
Attention: Missing default
 2-350 free(FreePtr);
Attention: Storage FreePtr);
 2-350 . free(FreePtr);
 2-390 msaw.2.2
 2-412 send_buffer = (U16 *) malloc(size+1);
Attention: Storage malloc(size+1);
 2-412 . send_buffer = (U16 *) malloc(size+1);
 2-490       // missing break
    {
      run_this; 
      // missing break
   }
Attention: Missing break in case
 2-560       // missing break
    {
      run_this; 
      // missing break
   }
Attention: Missing break in case
 2-596       // missing break
    {
      run_this; 
      // missing break
   }
Attention: Missing break in case

3 3 Result: result/source/pr-app/pr-app-MSAW123/msaw-02.c

4 4 Source: source/pr-app/pr-app-MSAW123/msaw-02.h
Note: OK Classification Marking
Note: Good Header

4 4 Result: result/source/pr-app/pr-app-MSAW123/msaw-02.h

5 5 Source: source/pr-app/pr-app-MSAW123/msaw-03.c
Note: OK Classification Marking
Note: Good Header
 3-15 msaw.3.1
 3-44    halt;
Attention: Classified text in wrong file name: halt
 3-44 .    halt;
 3-88 dead_code = D + E; 
Attention: Dead Code
 3-179 /* dead_code = A * B; */
Attention: Dead Code
 3-335       // missing break
    {
      run_this; 
      // missing break
   }
Attention: Missing break in case
 3-382 msaw.3.2

 3-411if (veg)
Warning: Missing curly brace looked as far as 417

 3-431if (veg)
Warning: Missing curly brace looked as far as 437

 3-537 Warning: goto Statement goto error;
  3-537 . goto error;
 3-617 dead_code = D + E; 
Attention: Dead Code
 3-623 dead_block = E * F; */
Attention: Dead Code
 3-647 msaw.3.3
 3-706 {
   case one:
   {
      switch (nested)
Attention: Missing default
 3-708    {
    {
      switch (nested)
Attention: Nested switch
 3-712             X = Y + Z;
             X = Y + Z;
         case:
Attention: Missing break in case
 3-841 {
   case one:
   {
      run_this;
      break;
   }
   case two:
   {
      run_this;
      break;
   }
   // missing default
}


if (A == B)
{
   A = B + C;
   D = E + F;
}

A = B*C;
A = B+C;

if (A < B)
{
   A = B + C;
   D = E + F;
}

A = B*C;
A = B*C;

if (A ne B)
{
   A = B + C;
   D = E + F;
}


if (A gt B)
{
   A = B + C;
   D = E + F;
}

A = B-C;
A = B+C;
A = B/C;
// max LOC 62

}


/*
-----------------------------------------------------------------------------
--| NAME:   msaw.3.4
Attention: Missing default
 3-898 msaw.3.4
 3-1024 msaw.3.5
 3-1116 msaw.3.6
 3-1140 dead_block = C * D; 
Attention: Dead Code
 3-1171    case:
    case:
Attention: Stacked case statements
 3-1172 
    // stacked case statements but only if there is a new line in between

   case:
Attention: Stacked case statements
 3-1173 .    // stacked case statements but only if there is a new line in between
 3-1175    case:
    case:
Attention: Stacked case statements
 3-1176    case:
    case:
Attention: Stacked case statements
 3-1182    default:
   {
      halt;
   }
Attention: Missing SwError
 3-1184       halt;
Attention: Classified text in wrong file name: halt
 3-1184 .       halt;

 3-1285 {
FATAL Compile Error: Missing curly brace LE breaks  path 
 3-1362 msaw.3.7

 3-1388if (veg)
Warning: Missing curly brace looked as far as 1393
 3-1503 A = (int)B + C;
Attention: Recasting (int)
 3-1548 {
   case one:
   {
      run_this;
      break;
   }
   case two:
   {
      run_this;
      break;
   }
   // missing default
}


if (A ne B)
{
   A = B + C;
   D = E + F;
}

A = B+C;
A = B/C;

if (A le B)
{
   A = B + C;
   D = E + F;
}


if (A le B)
{
   A = B + C;
   D = E + F;
}


if (A ge B)
{
   A = B + C;
   D = E + F;
}


switch (msaw stuff)
Attention: Missing default
 3-1621    halt;
Attention: Classified text in wrong file name: halt
 3-1621 .    halt;
 3-1706 msaw.3.8
 3-1809 /* LE SV TOC-2228 this is a msaw-03.8.24 req to halt*/
Attention: Classified text in wrong file name: halt
 3-1849 msaw.3.9
 3-1913 msaw.3.10
 3-1997 dead_block = C * D; 
Attention: Dead Code

 3-2011if (veg)
Warning: Missing curly brace looked as far as 2019
 3-2033 msaw.3.11
 3-2131 FreePtr = HmiStringPtr;
Attention: Storage FreePtr = HmiStringPtr;
 3-2131 . FreePtr = HmiStringPtr;
 3-2184 {
   case one:
   {
      switch (nested)
Attention: Missing default
 3-2186    {
    {
      switch (nested)
Attention: Nested switch
 3-2190             X = Y + Z;
             X = Y + Z;
         case:
Attention: Missing break in case
 3-2217 // TBD - what do I do now
Attention: Possible problem Keyword TBD
 3-2217 . // TBD - what do I do now
 3-2247 msaw.3.12
 3-2290 /* dead_code = A * B; */
Attention: Dead Code
 3-2307 /* LE SV TOC-2235 this is a msaw-03.12.12 req to halt*/
Attention: Classified text in wrong file name: halt
 3-2349 dead_code = B - C; 
Attention: Dead Code

Warning: Functions Exceed 12

Error: File with 1027 LOC 

5 5 Result: result/source/pr-app/pr-app-MSAW123/msaw-03.c

6 6 Source: source/pr-app/pr-app-MSAW123/msaw-03.h
Note: OK Classification Marking
Note: Good Header

6 6 Result: result/source/pr-app/pr-app-MSAW123/msaw-03.h

7 7 Source: source/pr-app/pr-app-MSAW123/msaw-04.c
Note: OK Classification Marking
Note: Good Header
 4-15 msaw.4.1
 4-46 msaw.4.2
 4-80 msaw.4.3

 4-105if (veg)
Warning: Missing curly brace looked as far as 124
 4-115 dead_block = E * F; */
Attention: Dead Code
 4-134 A = (long)B + C;
Attention: Recasting (long)
 4-220 /* LE SV TOC-2240 this is a msaw-04.3.43 req to halt*/
Attention: Classified text in wrong file name: halt
 4-228    case:
    case:
Attention: Stacked case statements
 4-229 
    // stacked case statements but only if there is a new line in between

   case:
Attention: Stacked case statements
 4-230 .    // stacked case statements but only if there is a new line in between
 4-232    case:
    case:
Attention: Stacked case statements
 4-233    case:
    case:
Attention: Stacked case statements
 4-239    default:
   {
      halt;
   }
Attention: Missing SwError
 4-241       halt;
Attention: Classified text in wrong file name: halt
 4-241 .       halt;
 4-280 msaw.4.4
 4-310 // ??? go see ws
Attention: Possible problem Keyword ??
 4-310 . // ??? go see ws
 4-320 // TBS - I need to figure this out
Attention: Possible problem Keyword TBS
 4-320 . // TBS - I need to figure this out
 4-490 dead_block = E * F; */
Attention: Dead Code
 4-498       // missing break
    {
      run_this; 
      // missing break
   }
Attention: Missing break in case
 4-560 msaw.4.5
 4-674 {
   case one:
   {
      switch (nested)
Attention: Missing default
 4-676    {
    {
      switch (nested)
Attention: Nested switch
 4-680             X = Y + Z;
             X = Y + Z;
         case:
Attention: Missing break in case
 4-713 msaw.4.6
 4-761 msaw.4.7
 4-813 // (P) this is really improtant
Attention: Classified text in wrong file name: (P)
 4-834 msaw.4.8
 4-899 free(FreePtr);
Attention: Storage FreePtr);
 4-899 . free(FreePtr);
 4-932 msaw.4.9
 4-1003 msaw.4.10

 4-1018if (veg)
Warning: Missing curly brace looked as far as 1023
 4-1064 dead_code = B - C; 
Attention: Dead Code

 4-1082if (veg)
Warning: Missing curly brace looked as far as 1094

 4-1091 A = (long)B + C;
FATAL Compile Error: LE breaks long path 
 4-1092 A = (long)B + C;
Attention: Recasting (long)

 4-1157 {
FATAL Compile Error: Missing curly brace LE breaks  path 
 4-1164 // TBD - what do I do now
Attention: Possible problem Keyword TBD
 4-1164 . // TBD - what do I do now
 4-1203 FreePtr = HmiStringPtr;
Attention: Storage FreePtr = HmiStringPtr;
 4-1203 . FreePtr = HmiStringPtr;
 4-1235 msaw.4.11
 4-1271 // TBD - what do I do now
Attention: Possible problem Keyword TBD
 4-1271 . // TBD - what do I do now
 4-1281 /* LE SV TOC-2251 this is a msaw-04.11.15 req to halt*/
Attention: Classified text in wrong file name: halt
 4-1333 {
   case one:
   {
      switch (nested)
Attention: Missing default
 4-1335    {
    {
      switch (nested)
Attention: Nested switch
 4-1339             X = Y + Z;
             X = Y + Z;
         case:
Attention: Missing break in case
 4-1362 A = (float)B + C;
Attention: Recasting (float)
 4-1445 msaw.4.12
 4-1501 msaw.4.13

 4-1521if (veg)
Warning: Missing curly brace looked as far as 1528
 4-1581 A = (long)B + C;
Attention: Recasting (long)
 4-1655 // ??? go see ws
Attention: Possible problem Keyword ??
 4-1655 . // ??? go see ws
 4-1688 msaw.4.14
 4-1703 send_buffer = (U16 *) malloc(size+1);
Attention: Storage malloc(size+1);
 4-1703 . send_buffer = (U16 *) malloc(size+1);
 4-1715    halt;
Attention: Classified text in wrong file name: halt
 4-1715 .    halt;

 4-1720 Warning: goto Statement goto error;
  4-1720 . goto error;
 4-1744 // TBD - what do I do now
Attention: Possible problem Keyword TBD
 4-1744 . // TBD - what do I do now

Warning: Functions Exceed 14

Error: File with 710 LOC 

7 7 Result: result/source/pr-app/pr-app-MSAW123/msaw-04.c

8 8 Source: source/pr-app/pr-app-MSAW123/msaw-04.h
Note: OK Classification Marking
Note: Good Header

8 8 Result: result/source/pr-app/pr-app-MSAW123/msaw-04.h

Settings

This is a legacy report. IAT started with just this report. Use this report to look for keywords that point to potential problems in the software. Some of the more important keywords are TBD and stub. In future releases of software try not to use TBD for items such as future. If you are web enabled, try re-running the report with other keywords. New potential issues may be surfaced. Description 6

Master Directories

Project Instrumentation Test
Source Result Analysis
Metrics

Report Markings
Report Marking
Highest Code Classification
Lowest Code Classification
Classified Keywords

Headers
.*BEGIN PROLOGUE.*CLASSIFICATION.*FILE NAME.*ABSTRACT.*HISTORY.*CCCQ_VER.*END PROLOGUE C Header
.*BEGIN PROLOGUE.*CLASSIFICATION.*FILE NAME.*ABSTRACT.*HISTORY.*CCCQ_VER.*END PROLOGUE H Header
.*BEGIN PROLOGUE.*CLASSIFICATION.*FILE NAME.*ABSTRACT.*HISTORY.*CCCQ_VER.*END PROLOGUE asm Header

File Controls
Assembly Extensions
Access Files
Ignore Files
Paths
File Path
Src Paths (websever /~iat no websever ../../)
URL (websever /~iat no websever ../../ dos is blank)

Source Dir Path
Result Dir Path
Analysis Dir Path(no websever setting ../ft-red-B1B2D6_Ry)
Analysis Report Name
Files

toc file bfw file hmi file
toc html bfw html

General Settings
CPCs
1 2 3 4 5 6 7 Colors

Log Event Patterns
SV Events case Insensitive
Filter SV Events case Insensitive (e.g. traffic)
Filter Files case Insensitive
PURGE_BUFFER DB Events case Sensitive
HMI_CALL HMI Events case Sensitive
any\s*.\s*loc LOC Events case Sensitive
nnoonnee Filter LOC Events (e.g. traffic)

Table Driven Functions used by uncalled functions detector
nnoonnee

Fixed Keywords case insensitive
C
H
Assembly

Keywords case insensitive
debug|delay|return\;|while\(\d+\).|enable|disable|exception|demo|reuse|pragma|asap find 1
nnoonnee find 2
halt|\bstub\b|\? *:*|malloc|\balloc\b|\btbd\b|\btbs\b find 3
dedicated|buffer find 4
timeout| global|free|new |delete |goto|mutable|friend|explicit find 5

--\| ignore lines

Keyword Window

Hamming Patterns

Log Events
SV Start DB Start HMI Start LOC Start
Instrument Source LE Summary Auto Trace Fix LE English

Show in Details Report

Abstract SV REQUIRED Full Header All SourceCode Only SVCV src
Comments CV REQUIRED Rquirements Functions Show Only Affected Files Analyze Only LE SV

Reports
Control Menu Keywords Stats Metrics Ham Values Details Problem Summaries Problem Descriptions Compare

Reports - Automatic Detectors Default Problems Locked Files Date (e.g. 01/05/2003)

Fatal Printf C Headers H Headers ASM Headers

Class SV Marking CV Marking Keywords Code Keywords Prologues

No Curly Braces ifdef Switch Default's Default Error Case Break

Nested Switches Stacked Cases Calling Rules No Error Exit ?: operator

Func/File LOC/File Line Length < 5 LOC/Func > 100 LOC/Func

Uncalled Func's Dead Code Fuzzy Log Events ++/-- in if, else, while do Loops

malloc free Re-Casting goto No Func Header

Regression noise reduction for Automatic Detectors - must run regression.pl first
new files
mod files

Metrics Baseline Accessed
Metrics Saved (enable stats)

Hide Controls Show Checked Summary Checked Details Not Checked All

done
12/08/2003 16:09:13 start
12/08/2003 16:09:28 end

Abstract	SV REQUIRED	Full Header	All SourceCode	Only SVCV src
Comments	CV REQUIRED	Rquirements	Functions	Show Only Affected Files	Analyze Only LE SV

Fatal	Printf	C Headers	H Headers	ASM Headers
Class	SV Marking	CV Marking	Keywords Code	Keywords Prologues
No Curly Braces	ifdef	Switch Default's	Default Error	Case Break
Nested Switches	Stacked Cases	Calling Rules	No Error Exit	?: operator
Func/File	LOC/File	Line Length	< 5 LOC/Func	> 100 LOC/Func
Uncalled Func's	Dead Code	Fuzzy Log Events	++/-- in if, else, while	do Loops
malloc free	Re-Casting	goto	No Func Header